Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] odd output in restore mode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Greg Smith <gsmith(at)gregsmith(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM>
Subject: Re: [PATCHES] odd output in restore mode
Date: 2008-07-28 16:06:17
Message-ID: 488DEE79.4010004@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Greg Smith wrote:
> On Wed, 23 Jul 2008, Kevin Grittner wrote:
>
>> In our scripts we handle this by copying to a temp directory on the
>> same mount point as the archive directory and doing a mv to the
>> archive location when the copy is successfully completed. I think
>> that this even works on Windows. Could that just be documented as a
>> strong recommendation for the archive script?
>
> This is exactly what I always do. I think the way cp is shown in the 
> examples promotes what's really a bad practice for lots of reasons, 
> this particular problem being just one of them.
>
> I've been working on an improved archive_command shell script that I 
> expect to submit for comments and potential inclusion in the 
> documentation as a better base for other people to build on. This is 
> one of the options for how it can operate. It would be painful but not 
> impossible to convert a subset of that script to run under Windows as 
> well, at least enough to cover this particular issue.
>
>

A Perl script using the (standard) File::Copy module along with the 
builtin function rename() should be moderately portable. It would to be 
nice not to have to maintain two scripts.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Marko KreenDate: 2008-07-28 16:16:48
Subject: dblink security
Previous:From: Andrew DunstanDate: 2008-07-28 16:01:40
Subject: Re: Do we really want to migrate plproxy and citext into PG core distribution?

pgsql-patches by date

Next:From: Gregory StarkDate: 2008-07-28 16:33:29
Subject: Re: WITH RECUSIVE patches 0723
Previous:From: Greg SmithDate: 2008-07-28 15:59:12
Subject: Re: [PATCHES] odd output in restore mode

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group