Re: [PATCHES] GIN improvements

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] GIN improvements
Date: 2008-07-23 13:39:49
Message-ID: 488734A5.9030503@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> once, for regular VACUUM I think you really have to call it within
> each bulkdelete operation.

Exactly what I did in last patch.

> There's probably no point in optimizing
> it away in VACUUM FULL either, since surely it'll be fast to call
> index_cleanup when there's nothing in the pending list?

Sure, with empty pending list insertcleanup will just lock/unlock metapage.

> Yeah, I was going to complain about that next :-). Autovacuum isn't
> going to trigger as a result of INSERT operations; somehow we have
> to teach it what to do for GIN indexes. I remember we discussed this
> at PGCon but I don't think we decided exactly what to do...
So, may be we just move insertcleanup call to ginbulkdelete/ginvacuumcleanup
but leave aminsertcleanup field in pg_proc for a future.

> I've already made a number of changes to the patch; let me keep working
> on it and send it back to you later.
ok

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2008-07-23 13:54:35 WITH RECUSIVE patches 0723
Previous Message Oleg Bartunov 2008-07-23 11:44:27 Re: [GENERAL] Fragments in tsearch2 headline

Browse pgsql-patches by date

  From Date Subject
Next Message Tatsuo Ishii 2008-07-23 13:54:35 WITH RECUSIVE patches 0723
Previous Message Simon Riggs 2008-07-23 10:59:43 Re: [PATCHES] odd output in restore mode