Skip site navigation (1) Skip section navigation (2)

Re: page macros cleanup (ver 04)

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: page macros cleanup (ver 04)
Date: 2008-07-08 19:28:27
Message-ID: 4873BFDB.7020702@sun.com (view raw or flat)
Thread:
Lists: pgsql-patches
Pavan, Heikki,

Is it OK now or do you have any comments?

	Thanks Zdenek

Zdenek Kotala napsal(a):
> Pavan Deolasee napsal(a):
>> On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas
>> <heikki(at)enterprisedb(dot)com> wrote:
>>>
>>> No, there's a itemsz = MAXALIGN(itemsz) call before the check against
>>> HashMaxItemSize.
>>>
>>
>> Ah, right. Still should we just not MAXALIGN_DOWN the Max size to
>> reflect the practical limit on the itemsz ? It's more academical
>> though, so not a big deal.
> 
> Finally I use following formula:
> 
> #define HashMaxItemSize(page) \
>      MAXALIGN_DOWN(PageGetPageSize(page) - \
>        ( SizeOfPageHeaderData + sizeof(ItemIdData) ) - \
>         MAXALIGN(sizeof(HashPageOpaqueData)) )
> 
> 
> I did not replace PageGetPageSize(page), because other *MaxItemSize has 
> same interface.
> 
> Revised patch is attached.
> 
>         Zdenek
> 
> 
> ------------------------------------------------------------------------
> 
>

In response to

pgsql-patches by date

Next:From: David FetterDate: 2008-07-09 00:38:00
Subject: Re: [PATCHES] WITH RECURSIVE updated to CVS TIP
Previous:From: Florian G. PflugDate: 2008-07-08 19:12:40
Subject: Re: [PATCHES] Solaris ident authentication using unix domain sockets

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group