Pavan Deolasee napsal(a):
> On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas
> <heikki(at)enterprisedb(dot)com> wrote:
>>
>> No, there's a itemsz = MAXALIGN(itemsz) call before the check against
>> HashMaxItemSize.
>>
> 
> Ah, right. Still should we just not MAXALIGN_DOWN the Max size to
> reflect the practical limit on the itemsz ? It's more academical
> though, so not a big deal.

Finally I use following formula:

#define HashMaxItemSize(page) \
  	MAXALIGN_DOWN(PageGetPageSize(page) - \
  	  ( SizeOfPageHeaderData + sizeof(ItemIdData) ) - \
  	   MAXALIGN(sizeof(HashPageOpaqueData)) )


I did not replace PageGetPageSize(page), because other *MaxItemSize has same 
interface.

Revised patch is attached.

		Zdenek

-- 
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql

In response to

• Re: page macros cleanup at 2008-07-04 11:04:15 from Pavan Deolasee

Responses

• Re: page macros cleanup (ver 04) at 2008-07-08 19:28:27 from Zdenek Kotala
• Re: page macros cleanup (ver 04) at 2008-07-09 11:54:08 from Heikki Linnakangas

pgsql-patches by date

Next:	From: Heikki Linnakangas	Date: 2008-07-04 12:20:45
	Subject: Re: Relation forks & FSM rewrite patches
Previous:	From: Zdenek Kotala	Date: 2008-07-04 11:47:00
	Subject: Re: page macros cleanup