Skip site navigation (1) Skip section navigation (2)

Re: Enabling SQL text field in the SQL tab of object dialog

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Date: 2008-07-01 10:52:22
Message-ID: 486A0C66.1040906@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge a écrit :
> Dave Page a écrit :
>> On Fri, Jun 20, 2008 at 12:48 AM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Done. I thought we didn't hide UI objects, only disable them, to get 
>>> a more
>>> consistant UI.
>>
>> On a single dialogue we disable objects so that dialogue will always
>> have the same layout no matter what server you're connected to. The
>> design from dialogue to dialogue may change as appropriate however.
>>
>>> The button text doesn't please me. Neither do the message box text. 
>>> If one
>>> has a better idea, I'll be glad to know about it.
>>
>> How about 'Lock DDL' for the checkbox? The message box could be 
>> something like:
>>
>> Locking the DDL will replace it with generated SQL. Are your sure you
>> wish to lose the changes you have made?
>>
>> I can't help thinking that 'Lock DDL' is unnecessarily obscure though.
>> Maybe 'Read only' is better.
>>
> 
> I like "Lock DDL". Perhaps "Read only DDL" would please you more ?
> 
>> In anycase, there are still some sizing issues to resolve - see the
>> attach screenshots for examples.
>>
> 
> It is great on GTK. I really should get a windows build system... and a 
> Mac Mini :)
> 

I'm at the PostgreSQL booth, for the RMLL in Mont-de-Marsan 
(http://rmll.info). I'm trying the wifi system :)

Here is the patch that fixes your issue on Win32. Works great on Win32 
and Linux... I'm not sure for Mac OS X though.


-- 
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com

Attachment: enablingsqltextfield_v4.patch
Description: text/x-patch (8.0 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-07-01 15:17:49
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Previous:From: Dave PageDate: 2008-06-30 07:49:08
Subject: Re: Support for integrated tsearch configuration

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group