I'd like to see some quick testing of this thing mentioned in the comments:
> * XXX if pgstat_track_activity_query_size is really large,
> * it might be best to use strcpy not memcpy for copying the
> * activity string?
If we make it a GUC, there will be people running with "really large"
pgstat_track_activity_query_size settings. In fact I wouldn't be
surprised if people routinely cranked it up to the 10-100 KB range, just
It's going to be platform-dependent, for sure, but some quick
micro-benchmarks of where the break-even point between memcpy and strcpy
lies would be nice.
In response to
pgsql-patches by date
|Next:||From: Thomas Lee||Date: 2008-06-24 14:16:32|
|Subject: Re: [UPDATED] A GUC variable to replace PGBE_ACTIVITY_SIZE|
|Previous:||From: Bruce Momjian||Date: 2008-06-24 12:29:44|
|Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore
from being affected by statement_timeout|