Skip site navigation (1) Skip section navigation (2)

Re: Enabling SQL text field in the SQL tab of object dialog

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Date: 2008-06-17 21:51:30
Message-ID: 485831E2.2060108@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> On Tue, Jun 17, 2008 at 8:59 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> 
>>> That can be
>>> potentially dangerous if the user has another property dialogue for a
>>> sibling object open though (actually that's an issue now iirc - this
>>> would just make it far more likely to occur).
>>>
>> What kind of issue are you talking about? can you give me an example?
> 
> When you open a properties dialogue, it gets passed a pointer to the
> pgObject which it may use right up until it is closed. If you refresh
> part of the tree, you delete and recreate all the pgObjects under the
> node you refresh, so the dialogue can end up with a pointer to an
> object that's been deleted.
> 

OK, but this is already an issue.

Here is patch revision 2. It creates a new textfield for the second SQL 
query, and it takes care of the refresh of the tree. This patch seems to 
resolve all issues I could find (apart from the one above).

Comments?


-- 
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com

Attachment: enablingsqltextfield_v2.patch
Description: text/x-patch (7.1 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-06-18 08:53:03
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Previous:From: Dave PageDate: 2008-06-17 08:02:07
Subject: Re: Enabling SQL text field in the SQL tab of object dialog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group