Re: A fix and a new functionnality for the colour patch

Dave Page a écrit :
> On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Hi,
>>
>> The colour patch commited by Dave during pgCon2008 allows a user to add a
>> background color to the treeview for each specific registered server.
>>
>> When a user deletes the colour in the server's property, pgAdmin will use a
>> black (#000000) background. The treeview node's text will be unreadable.
>> What the patch does is impliying white colour when the user doesn't spécify
>> a colour.
>
> Hmm, thought I covered that cased. Thanks for catching.
>

At least, it didn't work on GTK+.

>> The new functionality adds a colour button that opens the standard colour
>> dialog. The user doesn't new to know the HTML colour coding.
>
> Is the colour dialog available on all platforms?

AFAIK, yes, it does.

According to the manual
(http://docs.wxwidgets.org/2.8.6/wx_commondialogsoverview.html), "Some
dialogs have both platform-dependent and platform-independent
implementations, so that if underlying windowing systems do not provide
the required functionality, the generic classes and functions can stand in."

> I did look for one
> when writing the original patch but couldn't find it. It's possible I
> was hungover from the Jagermeister the night before though (EDB party
> at pgCon :-) ).
>

hehe :)

>> Comments?
>
> You spelt colour wrong :-). Other than that (and the possible issue
> above), looks good.
>

Yeah, my first (unsent) mail used color. I changed all color with colour
because of the spelling in pgAdmin :)

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com