Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Sigh ...

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-02 23:05:05
Message-ID: 481B9E21.4050201@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>   
>> ! 		print O "#define RELSEG_SIZE ",
>> ! 			(1024 / $self->{options}->{blocksize}) * 
>> ! 				$self->{options}->{segsize} * 1024, "\n";
>>     
>
> This doesn't look quite right; unless the arithmetic is being done in
> floating point?  I had it like this in configure.in:
>
> RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`
>   

blocksize is one of (1,2,4,8,16,32)  so it should always be a factor of 
1024 unless my arithmetic is awry. I did it that way because I dislike 
expressions with  unbracketed mixed operations - they make me think too 
much.

> Also it looks like you missed adding segsize to the config.pl comments.
>
> 			
>   

That's deliberate - we are currently only allowing a value of 1 here, so 
I don't see any point in putting it in the sample config file, even as a 
comment. When we enable other seg sizes we can add it to the sample file.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-05-02 23:19:00
Subject: Re: ecpg localization
Previous:From: Tom LaneDate: 2008-05-02 22:28:41
Subject: Re: [COMMITTERS] pgsql: Sigh ...

pgsql-committers by date

Next:From: Tom LaneDate: 2008-05-02 23:23:34
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Tom LaneDate: 2008-05-02 22:50:21
Subject: pgsql: Update documentation for psql relation-size-in-\dt+ patch.

pgsql-patches by date

Next:From: Tom LaneDate: 2008-05-02 23:05:52
Subject: Re: plpgsql CASE statement - last version
Previous:From: Tom LaneDate: 2008-05-02 22:28:41
Subject: Re: [COMMITTERS] pgsql: Sigh ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group