Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Sigh ...

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-02 22:18:29
Message-ID: 481B9335.5070407@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches

Tom Lane wrote:
>> However, all the values are hardcoded, so nothing in it should relate to 
>> settings that come from configure, I believe. These should be dealt with 
>> in src/tools/msvc/Solution.pm (mostly in GenerateFiles() ).
>>     
>
> FYI, I'm about to commit changes moving XLOG_BLCKSZ and XLOG_SEG_SIZE
> into the domain of configurable stuff, too.
>
> 			
>   

This patch should fix things for both sets of changes. And it 
demonstrates pretty much what you need to do for config options for MSVC.

If there's no objection I will apply shortly.

cheers

andrew

Attachment: mscvfix.patch
Description: text/x-patch (5.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-05-02 22:28:41
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Tom LaneDate: 2008-05-02 21:53:31
Subject: Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)

pgsql-committers by date

Next:From: Tom LaneDate: 2008-05-02 22:28:41
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Tom LaneDate: 2008-05-02 21:26:10
Subject: pgsql: Allow the planner's estimate of the fraction of a cursor's rows

pgsql-patches by date

Next:From: Tom LaneDate: 2008-05-02 22:28:41
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Previous:From: Tom LaneDate: 2008-05-02 21:28:31
Subject: Re: GUC parameter cursors_tuple_fraction

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group