Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Sigh ...

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Sigh ...
Date: 2008-05-02 07:57:43
Message-ID: 481AC977.8030609@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches

Tom Lane wrote:
> Log Message:
> -----------
> Sigh ... pg_config.h.win32 needs to define BLCKSZ and RELSEG_SIZE now.
>   

Tom,

this reminds me a bit of Talleyrand's reply to the beggar who said to 
him "Monseigneur, il faut que je vive," ... "Je n'en vois pas la 
nécessité.".

This fix is surely wrong for several reasons:
. the configure changes only broke MSVC builds, not all Windows builds 
(see narwhal, for example), but this change applies to both.
. fixing a change that adds a configure option by hardcoding it in 
pg_config.h.win32 is simply the wrong fix - the right fix is to add the 
equivalent logic to src/tools/Solution.pm.

I don't mind if you ask someone (realistically that will usually be 
Magnus or me) to unbreak MSVC builds due to a configure change, because 
you are not set up to test it yourself. But I do mind the wrong solution 
being applied just to unbreak the buildfarm.

I make corrective surgery in the morning.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Zdenek KotalaDate: 2008-05-02 08:05:33
Subject: Re: Regression test fails when BLCKSZ is 1kB
Previous:From: tomasDate: 2008-05-02 05:51:47
Subject: Re: GDB X Postgresql 8 - Failed to read a valid object file image from memory

pgsql-committers by date

Next:From: Peter EisentrautDate: 2008-05-02 09:27:51
Subject: pgsql: One-letter backslash commands now need a space before the first
Previous:From: Tom LaneDate: 2008-05-02 03:41:46
Subject: pgsql: Sigh ...

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2008-05-02 11:55:45
Subject: Re: plpgsql CASE statement - last version
Previous:From: Joshua D. DrakeDate: 2008-05-02 07:04:41
Subject: Re: configure option for XLOG_BLCKSZ

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group