Skip site navigation (1) Skip section navigation (2)

Re: float4/float8/int64 passed by value with tsearchfixup

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: float4/float8/int64 passed by value with tsearchfixup
Date: 2008-04-20 14:54:28
Message-ID: 480B5924.5030801@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-patches
Gregory Stark írta:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
>   
>> BTW, I trolled the contrib files for other v0 functions taking or
>> returning float4 or float8.  I found seg_size (fixed it) and a whole
>> bunch of functions in earthdistance.  Those use float8 not float4,
>> so they are not broken by this patch, but that module will have to
>> be v1-ified before we can consider applying the other part of the
>> patch.
>>     
>
> So are you killing V0 for non-integral types? Because if not we should keep
> some sacrificial module to the regression tests to use to test for this
> problem.
>
> I don't see any way not to kill v0 for non-integral types if we want to make
> float4 and float8 pass-by-value. We could leave those pass-by-reference and
> just make bigint pass-by-value.
>   

Just a note: time[stamp[tz]] also depend on either float8 or int64 and
they have to be the same pass-by-value or pass-by-reference  as their
base storage types. There were crashes or regression failures if not.

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/



In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2008-04-20 15:57:07
Subject: Re: float4/float8/int64 passed by value with tsearchfixup
Previous:From: Gregory StarkDate: 2008-04-20 12:32:59
Subject: Re: float4/float8/int64 passed by value with tsearchfixup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group