Skip site navigation (1) Skip section navigation (2)

Re: float4/float8/int64 passed by value with tsearch fixup

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: float4/float8/int64 passed by value with tsearch fixup
Date: 2008-04-19 18:56:02
Message-ID: 480A4042.5080102@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera írta:
> Zoltan Boszormenyi wrote:
>
>   
>>>> So I think we really do need to offer that compile-time option.
>>>> Failing to do so will be tantamount to desupporting v0 functions
>>>> altogether, which I don't think we're prepared to do.
>>>>     
>>>>         
>>> I have asked the Cybertec guys for a patch.  Since it's basically a copy
>>> of the float8 change, it should be easy to do.
>>>       
>> Here's the patch (against current CVS) with the required change.
>> Please review, it passed make check with both --enable and  
>> --disable-float4-byval.
>>     
>
> Does it pass "make installcheck" in contrib?  I'm worried about
>   

It seems to pass, see below.

> btree_gist in particular.  Perhaps the change I introduced in the
> previous revision needs to be #ifdef'd out?
>   

Both --enable and --disable-float4-byval produced only this regression,
but it seems to be a tuple order difference.

============= running regression test queries        ==============
test tsearch2             ... FAILED

cat tsearch2/regression.diffs:

*** ./expected/tsearch2.out     Tue Nov 20 05:23:10 2007
--- ./results/tsearch2.out      Sat Apr 19 20:48:16 2008
***************
*** 1490,1497 ****
   w0        |   29 |     29
   y9        |   29 |     29
   zm        |   29 |     29
-  zs        |   29 |     29
   zy        |   29 |     29
   ax        |   28 |     28
   cd        |   28 |     28
   dj        |   28 |     28
--- 1490,1497 ----
   w0        |   29 |     29
   y9        |   29 |     29
   zm        |   29 |     29
   zy        |   29 |     29
+  zs        |   29 |     29
   ax        |   28 |     28
   cd        |   28 |     28
   dj        |   28 |     28

======================================================================




-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/



In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2008-04-19 21:12:00
Subject: Re: float4/float8/int64 passed by value with tsearch fixup
Previous:From: Alvaro HerreraDate: 2008-04-19 18:25:57
Subject: Re: float4/float8/int64 passed by value with tsearchfixup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group