Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch - psql wraps at window width

From: Bryce Nesbitt <bryce2(at)obviously(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-17 04:12:47
Message-ID: 4806CE3F.2090908@obviously.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Bruce Momjian wrote:
> I spent time reviewing your patch --- quite impressive. I have attached
> and updated version with mostly stylistic changes.
>
> In testing I found the regression tests were failing because of a divide
> by zero error (fixed), and a missing case where the column delimiter has
> to be ":".  In fact I now see all your line continuation cases using ":"
> rather than "!".  It actually looks better --- "!" was too close to "|"
> to be easily recognized.  (Did you update your patch to use ":".  I
> didn't see "!" in your patch.)
Nice!  I'll merge with my current version.  As you note I changed to ":".

I also found that for hugely wide output it was better to give up (do 
nothing), rather than mangle the output in a futile attempt to squash it 
to the window width.  So there is one more clause in the wrapping if.

I have tested on several unix flavors, but not on Windows or cygwin.

                            -Bryce

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2008-04-17 06:11:12
Subject: Re: Lessons from commit fest
Previous:From: Bruce MomjianDate: 2008-04-17 02:49:00
Subject: Re: Proposed patch - psql wraps at window width

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2008-04-17 06:20:50
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Previous:From: Bruce MomjianDate: 2008-04-17 02:49:00
Subject: Re: Proposed patch - psql wraps at window width

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group