Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] MSVC build broken with perl 5.10

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Zeugswetter Andreas OSB SD <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] MSVC build broken with perl 5.10
Date: 2008-04-15 16:29:51
Message-ID: 4804D7FF.7050601@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Zeugswetter Andreas OSB SD wrote:
> Magnus Hagander wrote:
>   
>> I just tried the MSVC build on a system with ActiveState Perl 5.10,
>>     
> and
>   
>> it doesn't work. Some quick debugging before I downgraded to 5.8
>>     
> showed
>   
>> that this regexp in Project.pm line 262:
>>     my $replace_re = qr{^([^:\n\$]+\.c)\s*:\s*(?:%\s*:
>>     
> )?\$(\([^\)]+\))\/(.*)\/[^\/]+$};
>   
>> matches things properly using Perl 5.8 in for example
>> src/bin/initdb/Makefile (matches a total of around 10 Makefiles), but
>> in 5.10 it simply does not match anything...
>>
>> Any perl guru out there who can comment on why? ;-)
>>     
>
> The answer is actually simple, the \n needs the multiline modifier,
> and thus the m needs to be part of the quote-like operator.
>
> The perl doc states:
> 	"This operator quotes (and possibly compiles) its STRING"
> (it seems 5.8 did not compile, but 5.10 does)
>
> I feel that it is rather not a perl bug, and that the modifiers need to
> be put
> on the qr{}. I do not quite see why this re needs to be multiline in the
> first place,
> but I have not touched that in the attached patch, that is ready to
> apply.
> (modification works in perl 5.6, 5.8, 5.10)
>
>   


Thanks, that makes sense. I wonder how it ever worked before. Anyway, 
patch applied back as far as 8.2.

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2008-04-15 16:48:09
Subject: Re: Commit fest queue
Previous:From: Richard HuxtonDate: 2008-04-15 16:24:59
Subject: Re: Problem with site doc search

pgsql-patches by date

Next:From: Teodor SigaevDate: 2008-04-15 16:53:00
Subject: Re: Partial match in GIN (next vesrion)
Previous:From: Alvaro HerreraDate: 2008-04-15 15:06:23
Subject: Re: [PATCHES] Avahi support for Postgresql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group