Skip site navigation (1) Skip section navigation (2)

Re: Remove FATAL from pg_lzdecompress

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Remove FATAL from pg_lzdecompress
Date: 2008-04-10 19:45:08
Message-ID: 47FE6E44.8030201@sun.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane napsal(a):
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>>>> I attach patch which adds boundaries check and memory overwriting 
>>>> protection when compressed data are corrupted.
> 
>> Good point. Is there plan to applied also on other branch?
> 
> I wasn't planning to back-patch it.  Given the lack of field reports
> of compressed-data problems, it seemed to me that the risk of breaking
> something was larger than the chance of helping someone.  We could
> reconsider this after the code has been in HEAD awhile, perhaps.

Tom,

one of our customer with 3TB table it uses now in production (8.2) awhile (2 
weeks) and it works pretty well. He had a corrupted data in TOASTed table and 
now his system is stable without random crashes. I plan to use this patch in 
official Solaris build, but I prefer do not have differences between main stream 
and solaris binaries. Would be possible to backported this patch?

		Thanks Zdenek

In response to

pgsql-patches by date

Next:From: Andrew ChernowDate: 2008-04-10 19:57:45
Subject: Re: [PATCHES] libpq type system 0.9a
Previous:From: Andrew ChernowDate: 2008-04-10 19:39:35
Subject: Re: [PATCHES] libpq type system 0.9a

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group