Skip site navigation (1) Skip section navigation (2)

Re: printTable API (was: Show INHERIT in \du)

From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: printTable API (was: Show INHERIT in \du)
Date: 2008-03-30 16:06:59
Message-ID: 47EFBAA3.3060402@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Brendan Jurd wrote:
>  1. describe malloc's the cells to zero, but print just does a local
> calloc without any initialisation.

Um, calloc is the same as malloc + zero. Those two seem identical to me.

>  2. describe only does an mbvalidate for WIN32, but print does it in all cases.

There's this comment in describe.c:

> /*
>  * mbvalidate() is used in function describeOneTableDetails() to make sure
>  * all characters of the cells will be printed to the DOS console in a
>  * correct way
>  */

I don't know what that's about. Perhaps there's something in the archives...

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-03-30 16:16:46
Subject: Re: printTable API (was: Show INHERIT in \du)
Previous:From: PFCDate: 2008-03-30 14:41:51
Subject: Re: first time hacker ;) messing with prepared statements

pgsql-patches by date

Next:From: Tom LaneDate: 2008-03-30 16:16:46
Subject: Re: printTable API (was: Show INHERIT in \du)
Previous:From: Andreas 'ads' ScherbaumDate: 2008-03-30 10:49:17
Subject: Re: create language ... if not exists

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group