Skip site navigation (1) Skip section navigation (2)

Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Date: 2008-03-25 09:53:35
Message-ID: 47E8CB9F.6040006@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Zoltan Boszormenyi <zb(at)cybertec(dot)at> writes:
>   
>> Gregory Stark írta:
>>     
>>> 1) Please don't include configure in your patch. I don't know why it's checked
>>> into CVS but it is so that means manually removing it from any patch. It's
>>> usually a huge portion of the diff so it's worth removing.
>>>       
>
>   
>> Noted.
>>     
>
> Just for the record: the reason configure is in CVS is to avoid
> requiring users of CVS checkouts to have autoconf installed.
>
> Perhaps we should rethink that, but in any case there's no point
> in submitting manual diffs to configure (or any other generated
> file).  Best practice is to just remind the committer that the
> generated file needs to be regenerated.
>
>   
>>> 3) You could get rid of a bunch of #ifndef HAVE_LONG_INT_64 snippets by having
>>> a #define like INT64PASSBYVALUE which is defined to be either "true" or
>>> "false".
>>>       
>
>   
>> OK, this would also make the patch smaller.
>> Is pg_config_manual.h good for this setting?
>>     
>
> I'd go for having a #define like that, but what is the reason to set it
> in pg_config_manual.h?  Seems like the configure script should set it.
>   

Obviously. :-) Thanks.

And:

Magnus Hagander wrote:
>
> Changes to genbki.sh also have to be "mirrored" in the msvc build 
> scripts (Genbki.pm) in most cases...
>
>
> //Magnus

Thanks for the info, I modified this file as well.
Please review the change, I am not a Perl expert and
I don't have a Windows build environment.

New patch is attached.

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/


Attachment: pg84-passedbyval-v4.patch.gz
Description: application/x-tar (6.1 KB)

In response to

Responses

pgsql-patches by date

Next:From: Martin PihlakDate: 2008-03-25 12:16:38
Subject: Re: stored procedure stats in collector
Previous:From: Zoltan BoszormenyiDate: 2008-03-25 09:53:17
Subject: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group