Skip site navigation (1) Skip section navigation (2)

Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>
Subject: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Date: 2008-03-24 23:46:03
Message-ID: 47E83D3B.1070405@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-patches
Zoltan Boszormenyi írta:
> Gregory Stark írta:
>> 4) Your problems with tsearch and timestamp etc raise an interesting 
>> problem.
>>    We don't need to mark this in pg_control because it's a purely a 
>> run-time
>>    issue and doesn't affect on-disk storage. However it does affect ABI
>>    compatibility with modules. Perhaps it should be added to
>>    PG_MODULE_MAGIC_DATA.
>>   
>
> I am looking into it.

Do you think it's actually needed?
PG_MODULE_MAGIC_DATA contains the server version
the external module was compiled for. This patch won't go to
older versions, so it's already protected from the unconditional
float4 change. And because you can't mix server and libraries
with different bitsize, it's protected from the conditional int64,
float8, etc. changes.

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/



In response to

Responses

pgsql-patches by date

Next:From: Zoltan BoszormenyiDate: 2008-03-25 00:11:07
Subject: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Previous:From: Zoltan BoszormenyiDate: 2008-03-24 23:38:33
Subject: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group