Skip site navigation (1) Skip section navigation (2)

Re: Hash Index Build Patch v2

From: Tom Raney <twraney(at)comcast(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Shreya Bhargava <shreya_bhargav(at)yahoo(dot)com>
Subject: Re: Hash Index Build Patch v2
Date: 2008-03-18 01:52:11
Message-ID: 47DF204B.9010804@comcast.net (view raw or flat)
Thread:
Lists: pgsql-patches
Tom,

Thanks for your comments and for your work incorporating our patch into 
8.4.  This will help us provide even a better patch next time around :)

-Shreya Bhargava and Tom Raney

> Tom Raney <twraney(at)comcast(dot)net> writes:
>   
>> This revised version of our patch uses the function estimate_rel_size() 
>> from plancat.c to estimate the number of tuples in the parent relation.  
>> This method is an alternative to scanning the parent relation to 
>> estimate the number of tuples, as we did in the first version of the patch.
>>     
>
> Applied after significant editorialization.  You need to pay more
> attention to conforming to the style of the surrounding code and to
> updating comments that your work renders inaccurate.
>
> 			regards, tom lane
>
>   


In response to

pgsql-patches by date

Next:From: KaiGai KoheiDate: 2008-03-18 02:02:36
Subject: Re: [PATCHES] [0/4] Proposal of SE-PostgreSQL patches
Previous:From: Joshua D. DrakeDate: 2008-03-18 01:50:38
Subject: Re: [PATCHES] [0/4] Proposal of SE-PostgreSQL patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group