Skip site navigation (1) Skip section navigation (2)

Re: Fix pgstatindex using for large indexes

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tatsuhito Kasahara <kasahara(dot)tatsuhito(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix pgstatindex using for large indexes
Date: 2008-02-25 15:26:19
Message-ID: 47C2DE1B.1050703@sun.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane napsal(a):
> Tatsuhito Kasahara <kasahara(dot)tatsuhito(at)oss(dot)ntt(dot)co(dot)jp> writes:
>> In pgstatindex.c and pgstattuple.sql, some variables are defined with
>> int type. So when we try to get informations about a large index by using
>> pgstatindex, we get strange value of size and density.
>> Because the values exceed int-max.
>> ...
>> I think that max_avail and free_space should be uint64.
> 
> Most places where we've dealt with this before, we use double, which is
> guaranteed to be available whereas uint64 is not ...

Is this requirement still valid? Is there any currently supported platform which 
does not have uint64? IIRC we are going to change datetime to integer for 8.4. 
By my opinion uint64 is suitable for head and probably for 8.2 and 8.3 as well.


64bit integer is already used on many places: e.g.

./commands/copy.c
./tcop/utility.c.
./optimizer/plan/planner.c



		Zdenek

In response to

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2008-02-25 16:04:26
Subject: Re: [PATCHES] Avahi support for Postgresql
Previous:From: Peter EisentrautDate: 2008-02-25 14:45:42
Subject: Re: Avahi support for Postgresql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group