Skip site navigation (1) Skip section navigation (2)

Re: Oops - BF:Mastodon just died

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dpage(at)postgresql(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Oops - BF:Mastodon just died
Date: 2008-01-31 15:21:09
Message-ID: 47A1E765.4020005@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>   
>>>> Agreed, but I suggest waiting till 8.4 is branched unless you are really
>>>> sure about this addition.  We freeze for 8.3.0 in less than 24 hours.
>>>>         
>
>   
>> I am pretty damn sure it's OK. It's pretty low risk (change an unlink 
>> call to a rename call) and even if it's broken as my fist version was, 
>> it doesn't appear to break the build. It's working on the buildfarm. I 
>> want it in so if we have problems with 8.3 we don't have to go through 
>> the handstands I had to to find out what was broken.
>>     
>
> After looking at the patch, my only question is how all those junk files
> get cleaned up at "make clean".
>
> 			
>   

The symbols files we are keeping as a result of the patch are renamed 
into to the release or debug hierarchy (depending on what we're 
building). Those entire trees are removed by src/tools/msvc/clean.bat.

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-01-31 15:25:54
Subject: Re: {**Spam**} Re: [PATCHES] Proposed patch: synchronized_scanning GUC variable
Previous:From: Bruce MomjianDate: 2008-01-31 15:14:58
Subject: Re: Remove pg_dump -i option (was Re: Proposed patch: synchronized_scanning GUC variable)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group