Re: Declarative partitioning grammar

From: Markus Schiltknecht <markus(at)bluegap(dot)ch>
To: Jeff Cohen <jcohen(at)greenplum(dot)com>
Cc: Warren Turkal <turkal(at)google(dot)com>, Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>, Gavin Sherry <swm(at)alcove(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Declarative partitioning grammar
Date: 2008-01-14 09:49:34
Message-ID: 478B302E.3060207@bluegap.ch
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Jeff Cohen wrote:
> We did look at allowing general functions for partitioning and this was
> one concern. The other is that we want to enforce that a row only gets
> inserted into a single partition, so we wanted a declarative syntax
> where it was relatively easy to check that range and list specifications
> don't overlap.

Why do you need to define a split point so ambiguously at all? Why not
just give the DBA exactly *one* place to define the split point?

I don't think the separation into list, hash and range partitioning is
adequate. What is the system supposed to do, if you try to insert a row
which doesn't fit any of the values in your list or doesn't fit any of
the ranges you defined?

I prefer a partitioning grammar which doesn't interfere with
constraints. We all know how to define constraints. Please don't
introduce a new, ambiguous way. A partitioning definition should be able
to tell the target partition for *every* row which satisfies the
constraints (the real ones, not ambiguous ones).

IMO, a single DDL command should only touch a single split point, i.e.
split a table into two partitions, move the split point or remove the
split point (joining the partitions again). Those are the only basic
commands you need to be able to handle partitioning.

Sorry, but for my taste, the proposed grammar is too long per command,
not flexible enough and instead ambiguous for split points as well as
for constraints. To me it looks like repeating the mistakes of others.

Regards

Markus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jean-Michel Pouré 2008-01-14 09:57:12 Re: Postgresql Materialized views
Previous Message Simon Riggs 2008-01-14 09:34:45 Re: Transaction Snapshot Cloning