Skip site navigation (1) Skip section navigation (2)

Re: BUG #5394: invalid __declspec for PG_MODULE_MAGIC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Vladimir Barzionov" <snego(dot)barsik(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5394: invalid __declspec for PG_MODULE_MAGIC
Date: 2010-03-28 20:01:57
Message-ID: 4776.1269806517@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
"Vladimir Barzionov" <snego(dot)barsik(at)gmail(dot)com> writes:
> In fmgr.h,
> macros PG_MODULE_MAGIC, PG_FUNCTION_INFO_V1.. are declared with incorrect
> "storage-class". It uses PGDLLIMPORT for declare __declspec().

> In general for building external DLL module, PGDLLIMPORT must be
> __declspec(dllimport). As it is.

> However in PG_MAGIC_* macro, storage class for function must be
> __declspec(dllexport).

> Same problem was already discussed for example here
> http://dbaspot.com/forums/postgresql/393683-re-general-custom-c-function-pal
> loc-broken.html

> Looks like the simplest way for correcting the issue is declaring additional
> macro (something like PGMODULEEXPORT)

If you want us to change this, you need to give a specific example of
what's going wrong for you.  Just asserting that it's wrong adds nothing
whatsoever to the previous discussions.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-03-28 20:12:32
Subject: Re: join removal
Previous:From: Robert HaasDate: 2010-03-28 19:55:19
Subject: Re: join removal

pgsql-bugs by date

Next:From: Robert HaasDate: 2010-03-29 00:17:54
Subject: Re: BUG #5392: Query Optimization
Previous:From: Vladimir BarzionovDate: 2010-03-27 14:44:50
Subject: BUG #5394: invalid __declspec for PG_MODULE_MAGIC

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group