Skip site navigation (1) Skip section navigation (2)

Re: Unworkable column delimiter characters for COPY

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unworkable column delimiter characters for COPY
Date: 2007-12-27 19:23:12
Message-ID: 4773FBA0.5000509@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>   
>> Tom Lane wrote:
>>     
>>> I think at minimum we need to forbid b, f, n, r, t, v, which are the
>>> control character representations currently recognized by COPY.
>>> But I'm tempted to make it reject all 26 lower-case ASCII letters,
>>> as a form of future-proofing.  Thoughts?
>>>       
>
>   
>> Assuming this is only for non-CSV mode, it seems OK.
>>     
>
> On looking closer, 'x', octal digits, and '.' would also be trouble.
> So I made it reject a-z, 0-9, and dot.
>   

I take it upper case A-F are safe, even though they are hex digits, 
because they wouldn't immediately follow the backslash?

> It appears that the CSV mode is a few bricks shy of a load here as
> well: it will let you do CSV DELIMITER '"' resulting in entirely
> broken output.  It seems we ought to forbid delimiter from matching CSV
> quote or escape characters.  I'll let you clean up that case though...
>
> 			
>   

Lucky me. Ok, I'll look at it. Should be simple enough.

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2007-12-27 19:37:18
Subject: Re: Spoofing as the postmaster
Previous:From: Tom LaneDate: 2007-12-27 18:32:01
Subject: Re: Unworkable column delimiter characters for COPY

pgsql-patches by date

Next:From: Tom LaneDate: 2007-12-27 20:29:30
Subject: Archiver behavior at shutdown
Previous:From: Tom LaneDate: 2007-12-27 18:32:01
Subject: Re: Unworkable column delimiter characters for COPY

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group