Skip site navigation (1) Skip section navigation (2)

Re: buildenv.pl/buildenv.bat

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: buildenv.pl/buildenv.bat
Date: 2007-12-09 19:40:37
Message-ID: 475C44B5.6090203@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Magnus Hagander wrote:
>>
>> You seem to have misunderstood what I am suggesting. Of course we should 
>> document use of buildenv.pl in addition to the hacky fix to the .bat 
>> files. The hack is the part that would be invisible. The docs would be 
>> visible and contain what would be our ongoing practice.
>>     
>
> Correct, I was misunderstanding it :-)
>
> I still can't say I like that hack though. I'd rather document that you
> have to do it in the .bat file for docs + gui build. 
>
> But it's better than what I thought you were proposing :-)
>
>
>   

Well, I honestly think we can live with it for one cycle. As soon as 8.4 
opens I'll get to work converting these .bat files to pure one line 
wrappers.

Meanwhile, here's the proposed patch. If you want something else you'll 
have to do it.

I don't know how many people regularly build on Windows other than you, 
me and Dave.

cheers

andrew

Attachment: buildenv.patch
Description: text/x-patch (7.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-12-09 19:51:59
Subject: Re: Release Note Changes
Previous:From: Tom LaneDate: 2007-12-09 19:34:08
Subject: Re: whats the deal with -u ?

pgsql-patches by date

Next:From: Andrew ChernowDate: 2007-12-09 20:08:09
Subject: Re: PGparam timestamp question
Previous:From: Tom LaneDate: 2007-12-09 18:26:50
Subject: Re: PGparam timestamp question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group