I think I have found a small problem in pg_regress.
In convert_sourcefiles() it stats directories based on the current
working directory, but in convert_sourcefiles_in() it reads files based
in srcdir or abs_builddir.
The attached patch changes the behavior of pg_regress, so that it stats
the directories that it read the files from. This patch will also make
pg_regress fail if the directories are missing, instead of silently
ignoring the missing directories. If you think this fail-fast behavior
is undesirable, I can create a patch that just ignores the files (todays
behavior), or ignores them with a warning.
The attached patch is tested by running pg_regress in a non-standard
path and by running "make check", both on Solaris Nevada on x64.
Jørgen Austvik, Software Engineering - QA
Sun Microsystems Database Technology Group
pgsql-patches by date
|Next:||From: Alvaro Herrera||Date: 2007-11-26 15:30:00|
|Subject: Re: pg_regress: stat correct paths|
|Previous:||From: Brendan Jurd||Date: 2007-11-25 20:08:24|
|Subject: Re: [GENERAL] Empty arrays with ARRAY|