Skip site navigation (1) Skip section navigation (2)

Re: Patch to enable/disable rule on a table

From: Dave Page <dpage(at)postgresql(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Patch to enable/disable rule on a table
Date: 2007-11-23 17:09:57
Message-ID: 47470965.8080307@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge wrote:
> Hi all,
> 
> Here is a patch to support this new PostgreSQL 8.3 feature : the
> possibility to enable and disable a rule on a table.

Thanks, applied with minor changes:

- Correct the naming of pgRule::iSetEnabled to pgRule::SetEnabled, and
added iSetEnabled with the correct functionality. In a nutshell, the
functions prefixed with 'i' are used to setup the internal state of the
object (usually called by CreateObjects in the appropriate factory), but
not change it, whilst those without the 'i' actually change the object
and it's internal state. This was also broken in the Trigger
enable/disable code which I guess you probably copied - fixed there too.

- Added code to prevent the option being offered for rules under views
as the syntax isn't there to allow rules on views (or rules that make
views) to be enabled or disabled.

- Re-jigged the menus a touch as they were starting to look a little
messy with various new options being added.

Cheers, Dave.

In response to

Responses

pgadmin-hackers by date

Next:From: Joshua D. DrakeDate: 2007-11-23 17:45:05
Subject: Re: pgadmin3 1.8.0 for ubuntu/dapper and
Previous:From: svnDate: 2007-11-23 17:03:49
Subject: SVN Commit by dpage: r6827 - in trunk/pgadmin3: . pgadmin/frm pgadmin/include/schema pgadmin/schema

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group