Skip site navigation (1) Skip section navigation (2)

Fix pg_dump dependency on postgres.h

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Fix pg_dump dependency on postgres.h
Date: 2007-11-06 13:22:09
Message-ID: 47306A81.60402@sun.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Attached patch removes pg_dump dependency on postgres.h. The main reason 
for that was discussed there:

http://archives.postgresql.org/pgsql-hackers/2007-10/msg01261.php

This fix contains several steps:

1) I removed sugar word from postgres.h and put them closer to consumer 
:-). I created include/catalog/genbki.h which contains sugar words - 
macros for correct catalog data processing. All catalogs file now 
include this header.

2) I moved SEQ_MAXVALUE and SEQ_MINVALUE macros from sequence.h to 
postgres_config_manual.h


3) I created two new headers pg_type_fn.h and pg_proc_fn.h and I moved 
all extern function definition from related headers into them. Second 
possible solution could be let function definition into headers and 
fence them by #ifndef FRONTED.

	Let me know your comments.

		Thanks
			Zdenek

Attachment: pg_dump.patch.gz
Description: application/x-gzip (6.1 KB)

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2007-11-06 13:24:59
Subject: Re: Visibility map thoughts
Previous:From: Marko KreenDate: 2007-11-06 13:19:16
Subject: Re: Visibility map thoughts

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-11-06 14:27:07
Subject: Re: krb_match_realm
Previous:From: Tom LaneDate: 2007-11-05 20:58:05
Subject: Re: compiler warning fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group