Re: Win32: Minimising desktop heap usage

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Page <dpage(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Win32: Minimising desktop heap usage
Date: 2007-10-23 17:49:40
Message-ID: 471E3434.60306@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Dave Page <dpage(at)postgresql(dot)org> writes:
>> Tom Lane wrote:
>>> So don't initialize a local variable unless
>>> you're giving it an actually meaningful value.
>
>> The downside is that we see a useless warning that, if sufficiently
>> multiplied, might make it hard to see something we are interested in.
>
> [ looks again... ] Actually, I think you just proved my point for me.
> The ZeroMemory call should go away, no? (Does this mean that the
> Windows builds fail to detect dereferencing NULL? Bad if so.)

Windows builds don't fail to detect that in genereal. ZeroMemory,
however, has a protection specifically against being passed NULL input,
IIRC.

//Magnus

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-10-23 18:07:41 Re: Win32: Minimising desktop heap usage
Previous Message Heikki Linnakangas 2007-10-23 16:28:36 uuid.h on Debian