Re: 1.8-Beta5 Bug: sequence properties dialog produces wrong sql statement order

From: Dave Page <dpage(at)postgresql(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Horvath Gabor <dueyduey(at)freemail(dot)hu>, pgadmin-support(at)postgresql(dot)org
Subject: Re: 1.8-Beta5 Bug: sequence properties dialog produces wrong sql statement order
Date: 2007-10-17 10:12:09
Message-ID: 4715DFF9.2070007@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Guillaume Lelarge wrote:
> Dave Page a écrit :
>> Guillaume Lelarge wrote:
>>>> I guess the general ordering of the statements should be as follows:
>>>> 1 Any ALTER SEQUENCE MIN/MAXVALUE statements that widen the range
>>>> 2 SETVAL
>>>> 3 Any ALTER SEQUENCE MIN/MAXVALUE statements that narrow the range.
>>>>
>>> We can't add this kind of functionnality now because we have a RC
>>> release... we are in a sort of code freeze. Final 1.8 will be soon released.
>>>
>>> Nevertheless, we can add it to our todo list.
>> I was thinking of it as a bug rather than a feature - and as such was
>> looking at fixing it atm. That said, if I find any wierd corner cases, I
>> might hold off for now. Noone else has complained in the last 4 years!
>>
>
> If you add this, I think we need a RC2.

Why? It's a far more simple change than the pgAgent query was and we had
no problem with that.

I've tested what I've committed - if a couple of others can check that
there is no regression, I think thats fine.

/D

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2007-10-17 10:26:59 Re: pgAdmin 1.8RC1 - failed to launch on Mac OS X
Previous Message Dave Page 2007-10-17 10:09:25 Re: 1.8-Beta5 Bug: sequence properties dialog produces wrong sql statement order