Re: A bunch of minor issues

From: Dave Page <dpage(at)postgresql(dot)org>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: A bunch of minor issues
Date: 2007-09-27 12:17:46
Message-ID: 46FB9F6A.6090808@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Heikki Linnakangas wrote:
> Dave Page wrote:
>> Heikki Linnakangas wrote:
>>> There's some strings in calls to wxLogDebug, like "OnTargetComplete()
>>> called", that are wrapped in _() for translation. Aren't those just for
>>> developers, and therefore a waste of time to translate?
>> Yep. Removed.
>
> Here's a few more, though I must admit that translating "Someone created
> a new line ending style! Run, run for your lives!!" would be much more
> fun than the run-of-the-mill strings ;-).

Committed that bit.

> I also added a XXX-comment to a suspicious piece of code in
> sysLogger.cpp. It's comparing to a string that's marked for translation,
> that's apparently coming from the operating system. You might want to
> change it to a non-translated string or something.
>

But not that bit.

Thanks, Dave.

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2007-09-27 12:30:07 SVN Commit by dpage: r6682 - trunk/pgadmin3
Previous Message svn 2007-09-27 12:17:17 SVN Commit by dpage: r6681 - in trunk/pgadmin3/pgadmin: debugger frm