| From: | "Zeugswetter Andreas SB SD" <ZeugswetterA(at)spardat(dot)at> |
|---|---|
| To: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: extern + static issue in datetime.c |
| Date: | 2001-08-27 15:25:43 |
| Message-ID: | 46C15C39FEB2C44BA555E356FBCD6FA41EB388@m0114.s-mxs.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Current sources don't compile on AIX with xlc compiler because of the
> combined (and inconsistent ? or compiler bug) use of extern
> and static
> for the datetktbl in datetime.c.
>
> header unconditionally has:
> extern datetkn datetktbl[];
>
> source has:
> static datetkn datetktbl[] = {
>
> The usual approach would be to avoid that line in the header
> if included
>
> from datetime.c, but I think it would be better to use a const in this
> case.
>
> I think this is a general compatibility problem, and thus needs to be
> solved.
Attached is a patch that might be considered (remove static for these
globals).
Thanks
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| datetime.patch | application/octet-stream | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Barry Lind | 2001-08-27 16:29:58 | Re: JDBC changes for 7.2 - wish list item |
| Previous Message | Leandro Fanzone | 2001-08-27 12:49:23 | Re: C++ and bool constants (was Re: [NOVICE] gcc 3.0.1) |