Skip site navigation (1) Skip section navigation (2)

Re: Beta 2 Wednesday?

From: Dave Page <dpage(at)postgresql(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Beta 2 Wednesday?
Date: 2007-07-30 08:39:00
Message-ID: 46ADA3A4.4010007@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge wrote:
> Dave Page a écrit :
>> Guillaume Lelarge wrote:
>>> Sorry, I still reproduce it under PostgreSQL 8.2.4+ and PostgreSQL HEAD.
>>>
>>> Here are steps to reproduce problem :
>>>  - right click on a function
>>>  - choose Properties
>>>  - change function's name
>>>
>>> OK button will not be enabled, SQL string will not show.
>> Are you sure you're running the build you think you are? Following the
>> steps you detail above works perfectly on PostgreSQL 8.2.4 and
>> EnterpriseDB AS 8.2 for me. I've tried C, pl/pgsql and edbspl functions
>> (though the latter only on EDB of course).
>>
>> Not that it should matter, but this is SVN head of pgAdmin, running on XP.
>>
> 
> OK, I think I've found a fix to Pavel's issue. To check cbLanguage, we
> use GetCurrentSelection. When I try to change an already defined
> function, GetCurrentSelection always returns -1 which is an invalid
> value. If I use GetGuessedSelection (with every other changes needed to
> use ctlComboBox instead of wxComboBox), it works great. I'm not sure
> this is the right way to fix this, so here is the patch.
> 
> As always, comments welcomed.

Hmm, sounds like it might be platform specific issue, similar to (but
not the same) one Stefan fixed for me in wxMac before 2.8 was released.

What OS and version of wxWidgets is this?

I have no problem with the patch, so if this is reproducable with the
latest wx version, please go ahead and apply.

Regards, Dave.

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2007-07-30 08:45:55
Subject: Re: Beta 2 Wednesday?
Previous:From: Dave PageDate: 2007-07-30 08:34:56
Subject: Re: Small patch for tips.txt

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group