Skip site navigation (1) Skip section navigation (2)

Re: Issue on compiling pgAdmin trunk

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Issue on compiling pgAdmin trunk
Date: 2007-07-28 17:30:34
Message-ID: 46AB7D3A.2090101@lelarge.info (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Hi,
>>
>> I had an issue when I tried to compile pgAdmin today. I did a complete
>> svn update (I mean I first did rm -rf on my directory, then svn update,
>> then ./configure, then make). gcc is complaining about duplicate use of
>> DebuggerApiVersion :
>>
>> ../pgadmin/include/debugger/dbgPgConn.h:67: error: declaration of
>> 'DebuggerApiVersion dbgPgConn::DebuggerApiVersion()'
>> ../pgadmin/include/debugger/dbgPgConn.h:37: error: changes meaning of
>> 'DebuggerApiVersion' from 'typedef enum DebuggerApiVersion
>> DebuggerApiVersion'
>>
>> So I changed the Enum's name to DebuggerApiVersion_Enum and everything
>> compiles now. Nevertheless, I'm not sure I did right, even if it
>> compiles fine. So, here is my patch.
>>
>> Comments are more than welcome :)
> 
> Yeah, I spotted that in the auto-build last night. The fix seems sound,
> but I'm not keen on the name. Perhaps just DebuggerApiVersions (note the
> s)?
> 

You're right. DebuggerApiVersions is a much better name.

> Anyhoo, please commit if you have a minute.
> 

Done.

Thanks.


-- 
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->

In response to

pgadmin-hackers by date

Next:From: Devrim GÜNDÜZDate: 2007-07-28 18:05:53
Subject: Re: Small patch for tips.txt
Previous:From: Guillaume LelargeDate: 2007-07-28 17:29:47
Subject: Re: Beta 2 Wednesday?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group