Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] patch win32.mak of libpq

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: Dave Page <dpage(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org, pgsql-odbc(at)postgresql(dot)org
Subject: Re: [PATCHES] patch win32.mak of libpq
Date: 2007-07-26 19:28:59
Message-ID: 46A8F5FB.6060008@hagander.net (view raw or flat)
Thread:
Lists: pgsql-odbcpgsql-patches
Hiroshi Saito wrote:
>> Ok. So there are actually two ways to go about it:
>> 1) Discontinue support for MSVC6 and require MSVC8
>>
>> 2) Change it so that MSVC6 can still build libpq, just not with SSPI
>> support. This can be done by conditionally enabling ENABLE_SSPI, so it's
>> not that hard.
>>
>> The question is, if we go with option 2, is it something that anybody
>> actually will *use*?
> 
> I desire 1 as formal. However, It contains VC7.1 and VC8.
> Moreover, libpq.dll can be used by the module of VC6.

Is there any actual reason to keep VC7.1 support?

VC6 has one reason only to exist, and that's that it doesn't carry the
dependencies that VC8 does. But VC7 does (different ones, but just as many).

So if we're dropping support for VC6, my suggestion is that we drop
support for *any* win32 compiler other than VC8 and MingW gcc.


>> If I'm not mistaken, one of the original reasons we kept the win32.mak
>> method around after we had the "complete msvc build" was for the ODBC
>> folks. Are you saying that the ODBC guys are now happy with a MSVC8
>> build?
> 
> Yes, They are offered as comfortable environment. pgAdmin and that's
> right.!:-)
> However, psqlODBC also contains legacy VC6. They will clear a problem by
> the cause libpq.dll wire. Even if it may be adjusted from now on. probably.

I'm sorry, I don't fully understand you here. Which one of the following
three is it (or is it something else altogether)?

1) Does ODBC *require* a MSVC6 build libpq.dll?
2) Can ODBC work with MVC8 built libpq, but ODBC is built with MSVC6?
3) Can ODBC be built with MSVC8 and use the MSVC8 built libpq?

It would be unfortunate if ODBC has to ship with a different set of
dependencies than libpq, but as long as they build with either VC6 or
VC8 that shouldn't happen.

1 above would be really bad, but I'm 99% sure that's not so, since I've
actually tested SSPI auth with such a libpq.

IMO, the best option would be 3, but I don't know enough about the ODBC
driver to comment on there. I'll CC this to the odbc list so we can get
more input from other people there.

//Magnus

In response to

Responses

pgsql-odbc by date

Next:From: Hiroshi SaitoDate: 2007-07-27 02:10:17
Subject: Re: [PATCHES] patch win32.mak of libpq
Previous:From: Hiroshi SaitoDate: 2007-07-26 15:51:08
Subject: Re: patch win32.mak of libpq

pgsql-patches by date

Next:From: Hiroshi SaitoDate: 2007-07-27 02:10:17
Subject: Re: [PATCHES] patch win32.mak of libpq
Previous:From: Hiroshi SaitoDate: 2007-07-26 15:51:08
Subject: Re: patch win32.mak of libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group