Skip site navigation (1) Skip section navigation (2)

Re: msvc const warnings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: msvc const warnings
Date: 2007-07-24 19:40:58
Message-ID: 46A655CA.8060705@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> Tom Lane wrote:
>   
>> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>>     
>>> Can we just disable const checking for MSVCC in general without using the
>>> #pragmas? It clearly doesn't understand how const works making that warning
>>> from it useless.
>>>       
>> +1 ... any useful warning of this kind will be had from other compilers.
>>     
>
> Sure, there are a couple of places we can do it:
> 1) We can add the pragma at the top of the file, which will turn it off
> for that file, but keep it for other files.
> 2) We can turn it off on a per-project basis, meaning we turn it off for
> the entire backend and the entire psql, but not for other EXEs and DLLs.
> 3) We can just turn it off for everything
>
> Note that it'll of course turn off the warning in *all* cases, not just
> the "free const chra **"-one.
>
> Which way would be preferred?
>
>
>   

Since it's apparently useless anyway, I vote for everywhere.

cheers

andrew

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2007-07-24 19:41:10
Subject: Re: msvc const warnings
Previous:From: Magnus HaganderDate: 2007-07-24 19:31:19
Subject: Re: msvc const warnings

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group