Skip site navigation (1) Skip section navigation (2)

Re: plperl warnings on win32

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: plperl warnings on win32
Date: 2007-07-24 14:11:52
Message-ID: 46A608A8.9080401@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote:
>   
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>     
>>>   override CPPFLAGS += -DPLPERL_HAVE_UID_GID
>>> + # Perl on win32 contains /* within comment all over the header file,
>>> + # so disable this warning.
>>> + override CFLAGS += -Wno-comment
>>>   endif
>>>       
>> If you insist you can apply that in some way that makes it Windows-only.
>> I object strongly to the patch in this form, because it will mask our
>> own mistakes as well as one particular Perl build's mistakes.
>>     
>
> Uh, it's already inside a win32-only block. So it'll only affect mingw.
>
> Do you know of a way to do it from inside gcc, like the #pragma that exists
> for win32 to disable specific warnings? If so we could just disable it on
> the line before we #include the perl header, and re-enable it after...
>   

see

http://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html#Diagnostic-Pragmas


cheers

andrew

In response to

Responses

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-07-24 14:18:04
Subject: Re: plperl warnings on win32
Previous:From: Heikki LinnakangasDate: 2007-07-24 14:10:11
Subject: Re: Reviewing new index types (was Re: [PATCHES] Updated bitmap indexpatch)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group