Skip site navigation (1) Skip section navigation (2)

Re: Beta 2 Wednesday?

From: Dave Page <dpage(at)postgresql(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Beta 2 Wednesday?
Date: 2007-07-24 10:50:28
Message-ID: 46A5D974.40402@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge wrote:
> Guillaume Lelarge a écrit :
>> PS : so, I've no objection for beta 2 on wednesday.
>>
> 
> In fact, I have one. I just fixed a bug on the creation of a function
> without cost parameter but there's still one unfixed. It's in
> dlgFunction.cpp source file, method CheckChange. I think the problem is
> on these lines :
> 
>     if (!isProcedure || !connection->EdbMinimumVersion(8, 0))
>         CheckValid(enable, cbLanguage->GetCurrentSelection() >= 0,
> _("Please select language."));
> 
> 
> There's something wrong in this test with a vanilla PostgreSQL. When I
> comment these lines, I can apply my changes on a function's definition.
> Otherwise, the OK button remains disabled whatever changes I could have
> done. But I have absolutely no idea what's going wrong here. Dave, can
> you take a look at this before building beta 2 ? Thanks.

I couldn't reproduce the problem myself (against PG 8.2.4), but I agree
that the logic in the check is in need of attention. I've committed a
slightly more sane version - please check it's OK for you.

Thanks, Dave

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2007-07-24 13:32:21
Subject: SVN Commit by dpage: r6472 - trunk/pgadmin3
Previous:From: svnDate: 2007-07-24 10:48:54
Subject: SVN Commit by dpage: r6471 - trunk/pgadmin3/pgadmin/dlg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group