Skip site navigation (1) Skip section navigation (2)

Re: WIP CSV logs

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dpage(at)postgresql(dot)org>
Subject: Re: WIP CSV logs
Date: 2007-06-29 14:49:28
Message-ID: 46851BF8.6020005@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-patches

Andrew Dunstan wrote:
>
>
> Andrew Dunstan wrote:
>>
>> Here is a WIP patch of the CSV logs work brought up to date with CVS 
>> HEAD.  One large change I made was to multiplex the selects on the 
>> pipes - previously it waited on one then the other - this seems 
>> almost to defeat the purpose of using select() :-)
>>
>> It seems to work well on Unix - I will test later on Windows, which 
>> I'm slightly worried about.
>>
>> I also want to get an id for non-session processes. I think this can 
>> just be start-time+pid, just like for session processes, but we'll 
>> need to stash it somewhere (just for those cases). If we do that we 
>> will be able to set a primary key on the log table when we read the 
>> data in, which Greg Smith was worried about.
>>
>> I hope to get this polished off in the next 15 hours or so - after 
>> that I'm away for 12 days.
>>
>>
>
> Here is a slightly updated version. It compiles on Windows, but it 
> doesn't work - the CSV log file gets created but doesn't get any 
> content. Dave, Magnus - can you see what I've done wrong? The strange 
> thing is that I tried to do exactly the same thing for CSV as for 
> stderr, and the stderr file gets content just fine.
>
>

Further update attached. Includes some code cleanup, and now sets up a 
session-id for all processes, including postmaster, syslogger etc, so we 
can make a primary key on the log table of (session_id, line_number).

TODOs: fix on Windows, docs.

cheers

andrew

Attachment: csvlog-6.patch
Description: text/x-patch (51.4 KB)

In response to

Responses

pgsql-patches by date

Next:From: Dave PageDate: 2007-06-29 15:19:27
Subject: Re: WIP CSV logs
Previous:From: Jim NasbyDate: 2007-06-29 13:28:47
Subject: Re: [PATCHES] Doc update for pg_start_backup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group