Skip site navigation (1) Skip section navigation (2)

Re: Running all tests by default

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Running all tests by default
Date: 2007-06-04 15:18:53
Message-ID: 46642D5D.7060807@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> What happened to the idea to run all tests (including PL, ECPG, contrib(?)) by 
> default, that is, by the top-level check/installcheck targets.  Those who 
> want to run individual tests could still do so in the respective 
> subdirectories.  What requirements does the buildfarm have?
>   

I just realised that the answer to this last question is essentially
"none". The reason is that as luck would have it, buildfarm never runs
the top level check and installcheck targets - it runs them from the
src/test/regress directory. There will be changes needed in the MSVC
instructure - we'd need one or two new targets for the vcregress script
(checkall/installcheckall or some such).

However, to be sane we would also have to have the top-level default
make target build contrib (which I badly want to rename anyway), and
that will require a buildfarm change. Coordinating it won't be easy. I
suggest we plan on making changes exactly at the time that we branch
8.3. I can build in conditional logic based on the version and get an
amended script distributed ahead of time. If we don't want to coordinate
it with that I could also do things based on catversion or even a
preplanned timestamp.

I'd prefer not to make these changes before we branch, though, as 
there's a moderately high risk of buildfarm breakage that we don't need 
right now.

cheers

andrew


In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-06-04 15:30:58
Subject: Re: So, why isn't *every* buildfarm member failing ecpg right now?
Previous:From: Alvaro HerreraDate: 2007-06-04 15:04:26
Subject: Re: Autovacuum launcher doesn't notice death of postmaster immediately

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group