Re: msvc, build and install with cygwin in the PATH

From: Hannes Eder <Hannes(at)HannesEder(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: msvc, build and install with cygwin in the PATH
Date: 2007-05-30 11:56:24
Message-ID: 465D6668.7040508@HannesEder.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Magnus Hagander schrieb:
> Are you actually *running* the script from inside cygwin? How else does it
> pick up the wrong command processor?
>
I run the script within cmd.exe, but cygwin´s /usr/bin directory is in
my PATH, therefor cygwin dir executable is in the PATH (/usr/bin/dir).
Instead of running cmd.exe´s "dir" command, cygwin´s /usr/bin/dir is
invoked, when calling

open($D, "dir /b $subdirs $spec |") || croak "Could not list $spec\n";

but they do not work in the same way.

So my original patch just solves the issue to run
src/tools/msvc/install.(bat¦pl¦pm) while leaving the cygwin´s /usr/bin
in the PATH.
>> Is it worth doing this the "Perl-way" and using File::Find? If so, I can
>> work an a patch for that.
>>
> It's certainly cleaner that way, but I don't find it a major issue. But I'd
> rather see that fix than the other one.
>
Time permitting I´ll provide a patch.

Hannes.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-30 13:26:44 Re: TOAST usage setting
Previous Message Zeugswetter Andreas ADI SD 2007-05-30 11:04:33 Re: TOAST usage setting

Browse pgsql-patches by date

  From Date Subject
Next Message Pavan Deolasee 2007-05-30 13:27:01 Re: [pgsql-patches] Ctid chain following enhancement
Previous Message Magnus Hagander 2007-05-30 10:28:28 Re: msvc, build and install with cygwin in the PATH