Skip site navigation (1) Skip section navigation (2)

Re: msvc, build and install with cygwin in the PATH

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Hannes Eder <Hannes(at)HannesEder(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, magnus(at)hagander(dot)net
Subject: Re: msvc, build and install with cygwin in the PATH
Date: 2007-05-23 13:50:33
Message-ID: 465446A9.1050303@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Hannes Eder wrote:
> -    open($D, "dir /b $subdirs $spec |") || croak "Could not list $spec\n";
> +    open($D, "cmd /c dir /b $subdirs $spec |") || croak "Could not list $spec\n";
>   
>

What the heck are we doing here anyway? We should be doing this a la 
Perl - calling out to "dir /b" is surely not the best way to do this. If 
we need to recurse we should use File::Find.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-05-23 13:59:12
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Alvaro HerreraDate: 2007-05-23 13:40:39
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support

pgsql-patches by date

Next:From: Tom LaneDate: 2007-05-23 13:59:12
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Alvaro HerreraDate: 2007-05-23 13:40:39
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group