| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: UTF8MatchText |
| Date: | 2007-05-17 18:06:08 |
| Message-ID: | 464C9990.5010000@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Wait a second ... I just thought of a counterexample that destroys the
> entire concept. Consider the pattern 'A__B', which clearly is supposed
> to match strings of four *characters*. With the proposed patch in
> place, it would match strings of four *bytes*. Which is not the correct
> behavior.
>
>
From what I can see the code is quite careful about when it calls
NextByte vs NextChar, and after _ it calls NextChar.
So I'll test for this, but I think it's safe.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-17 18:16:51 | Re: UTF8MatchText |
| Previous Message | Joshua D. Drake | 2007-05-17 17:57:29 | Re: Patch queue triage |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-17 18:16:51 | Re: UTF8MatchText |
| Previous Message | Tom Lane | 2007-05-17 18:00:35 | Re: Seq scans status update |