| From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoiding unnecessary reads in recovery |
| Date: | 2007-04-28 10:20:52 |
| Message-ID: | 46332004.2080207@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Fri, 2007-04-27 at 12:22 +0100, Heikki Linnakangas wrote:
>> Patch implementing that attached. I named the function "ReadOrZeroBuffer".
>
> We already have an API quirk similar to this: relation extension. It
> seems strange to have two different kinds of special case API that are
> used alongside each other in XLogReadBuffer()
>
> Currently if we extend by a block we say
> buffer = ReadBuffer(reln, P_NEW);
>
> Why not just add another option, so where you use ReadOrZeroBuffer we
> just say
> buffer = ReadBuffer(reln, P_INIT);
Because ReadOrZeroBuffer needs the block number as an argument.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-04-28 10:22:59 | Re: Avoiding unnecessary reads in recovery |
| Previous Message | Simon Riggs | 2007-04-28 10:13:19 | Re: Avoiding unnecessary reads in recovery |