Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch
Date: 2007-04-16 22:39:22
Message-ID: 4623FB1A.5050605@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Zoltan Boszormenyi írta:
> Andrew Dunstan írta:
>> Florian G. Pflug wrote:
>>>>>>
>>>>>> bison -y -d  gram.y
>>>>>> conflicts: 2 shift/reduce
>>>
>>> I'ts been quite a time since I last used bison, but as far as I
>>> remember, you can tell it to write a rather details log about
>>> it's analysis of the grammar. That log should include more
>>> detailed information about those conflicts - maybe that helps
>>> to figure out their exact cause, and to find a workaround.
>>>
>>
>> You can almost always get rid of shift/reduce conflicts by unwinding 
>> some of the productions - resist the temptation to factor the 
>> grammar. The effect of this is to eliminate places where the parser 
>> has to decide between shifting and reducing. (This is why, for 
>> example, almost all the "drop foo if exists" variants require 
>> separate productions rather than using opt_if_exists.)
>>
>> cheers
>>
>> andrew
>
> Thanks. This idea solved one of the two shift/reduce conflicts.
> But the other one can only be solved if I put GENERATED
> into the reserved_keyword set. But the standard spec says
> it's unreserved. Now what should I do with it?

What should I do? Send it. :-)
Someone more familiar with bison can hopefully fix it...
Please, review.

Best regards,
Zoltán

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Geschwinde & Schönig GmbH
http://www.postgresql.at/


Attachment: psql-serial-40.diff.gz
Description: application/x-tar (28.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Aidan Van DykDate: 2007-04-16 22:44:08
Subject: Re: Hacking on PostgreSQL via GIT
Previous:From: SteveDate: 2007-04-16 22:13:54
Subject: Re: [HACKERS] choose_bitmap_and again (was Re: [PERFORM] Strangely Variable Query Performance)

pgsql-patches by date

Next:From: Simon RiggsDate: 2007-04-16 22:42:21
Subject: Re: scrollable cursor support without MOVE statement
Previous:From: Tom LaneDate: 2007-04-16 22:18:38
Subject: Re: scrollable cursor support without MOVE statement

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group