Re: [PATCH] Nested app support for complete-bundle.sh

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Nested app support for complete-bundle.sh
Date: 2007-04-15 17:19:55
Message-ID: 46225EBB.7030004@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Dave Page wrote:
> Florian G. Pflug wrote:
>> Hi
>>
>> That symlinking-Framworks idea proved to be easier than I
>> initially thought - here is a patch ;-)
>>
>> This patch also moves pkg to the end of the list of subdirs
>> in the main Makefile.am. If pkg is listed before debugger,
>> than complete-bundle.sh is run _before_ the debugger binary
>> is copied into the bundle, which obviously causes all kinds
>> of trouble ;-)
>
> Cool - I do notice that you haven't removed my
> if-appbundle-force-static-link hack - were you definitely testing a
> dynamic build? Either way, that hack should be removed again to properly
> enable this fix.

Yeah - I didn't include my changes to acinclude.m4 in the patch, because
it also includes other changes that I want to test more before I submit
them (The cleanup of SSL-Detection & usage of pg_config --libs that
we discussed). I wanted to mention that in my e-mail, but, well, I forgot...

Anyway, I did test the new complete-bundle.sh with a fully dynamic build,
and it seems to work fine. I don't have a postgres instance with the debugger
plugin running, so "fine" means "Complains about not being able to connect
to localhost". ;-)

greetings, Florian Pflug

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2007-04-15 18:56:49 Re: [PATCH] Nested app support for complete-bundl e.sh
Previous Message Dave Page 2007-04-15 17:09:44 Re: [PATCH] Nested app support for complete-bundle.sh