Skip site navigation (1) Skip section navigation (2)

Re: build/install xml2 when configured with libxml

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: build/install xml2 when configured with libxml
Date: 2007-04-14 19:27:56
Message-ID: 46212B3C.6050004@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>   
>> Peter Eisentraut wrote:
>>     
>>> But the policy is that the presence of features in the final build 
>>> should not depend on the incidental presence of features in the build 
>>> environment.  Either you select a feature, then it's built, or you 
>>> don't, then it's not.  So the only options we really have are adding 
>>> another switch for libxslt, or including it with libxml.  I'm not sure 
>>> which is better.
>>>       
>
>   
>> Then let's add a switch for libxslt.
>>     
>
> +1 --- the fact that so many buildfarm members only have one of the two
> libraries is pretty suggestive that that's common.  We shouldn't require
> both libraries to build the core xml features, if only because
> contrib/xml2 is expected to go away eventually, no?
>
> 	
>   

I don't think it should go away until we provide for equivalents in 
core, at least optionally.

Anyway, here's the patch.

cheers

andrew

Attachment: xml2.patch
Description: text/x-patch (16.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-04-14 22:02:53
Subject: Re: [HACKERS] choose_bitmap_and again (was Re: [PERFORM] Strangely Variable Query Performance)
Previous:From: Tom LaneDate: 2007-04-14 18:21:26
Subject: Re: [HACKERS] choose_bitmap_and again (was Re: Strangely Variable Query Performance)

pgsql-patches by date

Next:From: Tom LaneDate: 2007-04-14 22:02:53
Subject: Re: [HACKERS] choose_bitmap_and again (was Re: [PERFORM] Strangely Variable Query Performance)
Previous:From: Tom LaneDate: 2007-04-14 18:21:26
Subject: Re: [HACKERS] choose_bitmap_and again (was Re: Strangely Variable Query Performance)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group