Skip site navigation (1) Skip section navigation (2)

Re: CREATE TABLE LIKE INCLUDING INDEXES support

From: Trevor Hardcastle <chizu(at)spicious(dot)com>
To: NikhilS <nikkhils(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date: 2007-04-13 16:42:51
Message-ID: 461FB30B.3020907@spicious.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
NikhilS wrote:
> Hi Trevor,
>
>
>     +
>     +                                       parent_index_info =
>     BuildIndexInfo(parent_index); 
>
>
> The above is not used anywhere else in the code and seems redundant.
Yep, pulled that out.
>
>     +
>     +                                       ereport(NOTICE,
>     +                                                      
>     (errmsg("Index \"%s\" cloned.",
>     +                                                                      
>     RelationGetRelationName(parent_index)))); 
>
>
> DefineIndex will give out a message anyways for unique/primary keys. 
> The above seems additional to it.
The original reason for this was the support for copying all indexes, 
but it doesn't make much sense now. I've pulled it too.

Thanks for pointing those out. An updated patch is attached.

-Trevor Hardcastle


Attachment: like_including_indexes-3.patch
Description: text/plain (8.4 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-04-13 16:50:33
Subject: Re: [HACKERS] Full page writes improvement, code update
Previous:From: Simon RiggsDate: 2007-04-13 16:06:08
Subject: Re: [HACKERS] Full page writes improvement, code update

pgsql-patches by date

Next:From: Tom LaneDate: 2007-04-13 16:50:33
Subject: Re: [HACKERS] Full page writes improvement, code update
Previous:From: Simon RiggsDate: 2007-04-13 16:06:08
Subject: Re: [HACKERS] Full page writes improvement, code update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group