Skip site navigation (1) Skip section navigation (2)

Re: Bug in UTF8-Validation Code?

From: Mark Dilger <pgsql(at)markdilger(dot)com>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Subject: Re: Bug in UTF8-Validation Code?
Date: 2007-04-01 19:39:54
Message-ID: 46100A8A.5030006@markdilger.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Martijn van Oosterhout wrote:
> There's also the performance angle. The current mbverify is very
> inefficient for encodings like UTF-8. You might need to refactor a bit
> there...

There appears to be a lot of function call overhead in the current 
implementation.  In pg_verify_mbstr, the function pointer 
pg_wchar_table.mbverify is called for each multibyte character in a multibyte 
string.

Refactoring the way these table driven functions work would impact lots of other 
code.  Just grep for all files #including mb/pg_wchar.h for the list of them. 
The list includes interfaces/libpq, and I'm wondering if software that links 
against postgres might rely on these function prototypes?

mark

In response to

Responses

pgsql-hackers by date

Next:From: korrydDate: 2007-04-01 19:56:27
Subject: Re: Last minute mini-proposal (I know, Iknow)forPQexecf()
Previous:From: Jeroen T. VermeulenDate: 2007-04-01 19:30:14
Subject: Re: Oracle indemnifies PostgreSQL on its patents

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group